From 1a8d867b73a4fdea5bc17542dfe4da2df793f084 Mon Sep 17 00:00:00 2001
From: "Joseph.Rawlings" <root0091@gmail.com>
Date: Tue, 2 Dec 2025 08:19:13 -0500
Subject: [PATCH] refactor: enhance log initialization and update logic in
 Proxmox Firewall component to prevent duplicate entries and improve
 performance

---
 .../Servers/Proxmox/views/firewall.blade.php  | 44 +++++++++++++++++--
 1 file changed, 40 insertions(+), 4 deletions(-)

diff --git a/extensions/Servers/Proxmox/views/firewall.blade.php b/extensions/Servers/Proxmox/views/firewall.blade.php
index 4377cec7c..e85aa5dc1 100644
--- a/extensions/Servers/Proxmox/views/firewall.blade.php
+++ b/extensions/Servers/Proxmox/views/firewall.blade.php
@@ -323,18 +323,46 @@
 
             @if(count($firewallLogs) > 0)
                 <div
-                    wire:key="firewall-logs-table"
                     x-data="{
-                        logs: @js($firewallLogs),
+                        logs: [],
                         searchTerm: '',
                         sortField: 'timestamp_iso',
                         sortDirection: 'desc',
+                        initialized: false,
+                        seenRaws: new Set(),
                         initialize(initialLogs) {
-                            // This is called on x-init
+                            if (this.initialized) return;
+                            
+                            if (initialLogs && initialLogs.length > 0) {
+                                this.logs = initialLogs.map((log, index) => ({
+                                    index,
+                                    ...log,
+                                }));
+                                // Track which logs we've seen
+                                this.logs.forEach(log => {
+                                    if (log.raw) this.seenRaws.add(log.raw);
+                                });
+                                this.initialized = true;
+                            }
                         },
                         updateLogs(newLogs) {
                             if (!newLogs || newLogs.length === 0) return;
-                            this.logs = newLogs;
+                            
+                            // Filter out logs we've already seen
+                            const logsToAdd = newLogs.filter(log => {
+                                if (!log.raw) return false;
+                                if (this.seenRaws.has(log.raw)) return false;
+                                this.seenRaws.add(log.raw);
+                                return true;
+                            });
+                            
+                            if (logsToAdd.length > 0) {
+                                // Add new logs to the beginning (most recent first)
+                                this.logs = [...logsToAdd, ...this.logs].map((log, index) => ({
+                                    index,
+                                    ...log,
+                                }));
+                            }
                         },
                         sort(field) {
                             if (this.sortField === field) {
@@ -380,7 +408,15 @@
                             });
                         },
                     }"
+                    x-init="initialize(@js($firewallLogs))"
                     @logs-updated.window="updateLogs($event.detail.logs || $event.detail[0]?.logs || $event.detail[0] || [])"
+                    x-effect="
+                        // Watch for changes in the backend data and merge new logs
+                        const backendLogs = @js($firewallLogs);
+                        if (initialized && backendLogs && backendLogs.length > 0) {
+                            updateLogs(backendLogs);
+                        }
+                    "
                     class="space-y-4"
                 >
                     <div class="flex flex-col md:flex-row md:items-center md:justify-between gap-3">