Joseph.Rawlings/Virtnet.bond
Private
Public Access
1
0
Fork 0
Code Activity

feat: improve drive reattachment logic to safely remove unused entry after attaching volume

Browse Source
This commit is contained in:
Joseph.Rawlings
2025-12-05 04:55:21 -05:00
parent 9f8c4eef04
commit 352b98e0c7
1 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
extensions/Servers/Proxmox/Livewire/Storage.php
View File

@@ -1023,7 +1023,7 @@ class Storage extends Component
$diskConfig = implode(',', $configParts); $diskConfig = implode(',', $configParts);
// First, set the disk on the new bus // First, set the disk on the new bus (this attaches the volume)
$proxmox->request( $proxmox->request(
'/nodes/' . $this->server->node->name . '/qemu/' . $this->server->vm_id . '/config', '/nodes/' . $this->server->node->name . '/qemu/' . $this->server->vm_id . '/config',
'put', 'put',
@@ -1032,14 +1032,19 @@ class Storage extends Component
] ]
); );
// Then clear the unused slot (set to empty/none to remove the reference without deleting volume) // Then remove the unused entry using delete parameter
$proxmox->request( // This is safe because the volume is now attached to the new bus
'/nodes/' . $this->server->node->name . '/qemu/' . $this->server->vm_id . '/config', try {
'put', $proxmox->request(
[ '/nodes/' . $this->server->node->name . '/qemu/' . $this->server->vm_id . '/config',
$this->reattachingDriveKey => '', 'put',
] [
); 'delete' => $this->reattachingDriveKey,
]
);
} catch (\Exception $e) {
// Unused entry might already be cleaned up automatically, ignore this error
}
$this->notify("Drive reattached as {$targetKey} successfully.", 'success'); $this->notify("Drive reattached as {$targetKey} successfully.", 'success');
$this->closeReattachModal(); $this->closeReattachModal();