Joseph.Rawlings/Virtnet.bond
Private
Public Access
1
0
Fork 0
Code Activity

refactor: modify log loading behavior in Proxmox Firewall component to prevent event dispatch on initial load, enhancing performance and user experience

Browse Source
This commit is contained in:
Joseph.Rawlings
2025-12-02 15:48:17 -05:00
parent 2eb67b311b
commit 39f06a6293
2 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
extensions/Servers/Proxmox/Livewire/Firewall.php
View File

@@ -58,7 +58,7 @@ class Firewall extends Component
$this->loadFirewallOptions();
$this->loadFirewallRules();
$this->loadNetworkAdapters();
$this->loadFirewallLogs();
$this->loadFirewallLogs(false); // Don't dispatch event on initial load
}
protected function loadAvailableIps(): void
@@ -797,7 +797,7 @@ class Firewall extends Component
}
}
public function loadFirewallLogs(): void
public function loadFirewallLogs(bool $dispatchEvent = true): void
{
$this->logError = '';
try {
@@ -937,6 +937,11 @@ class Firewall extends Component
} elseif (empty($this->firewallLogs)) {
$this->logError = 'No firewall logs available. Ensure firewall logging is enabled in Proxmox (Datacenter > Firewall > Options).';
}
// Dispatch event only when manually refreshed (not on mount)
if ($dispatchEvent) {
$this->dispatch('logs-refreshed');
}
} catch (\Exception $e) {
$errorMessage = $e->getMessage();
if (method_exists($e, 'response') && $e->response()) {