From 83823e2103e407a40e967d90f247a46bcc37b911 Mon Sep 17 00:00:00 2001 From: "Joseph.Rawlings" Date: Thu, 4 Dec 2025 20:36:03 -0500 Subject: [PATCH] fix: clarify usage of ruleMacro in Firewall class, noting it is for UI convenience only --- extensions/Servers/Proxmox/Livewire/Firewall.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/extensions/Servers/Proxmox/Livewire/Firewall.php b/extensions/Servers/Proxmox/Livewire/Firewall.php index e74f0cb03..018c76af1 100644 --- a/extensions/Servers/Proxmox/Livewire/Firewall.php +++ b/extensions/Servers/Proxmox/Livewire/Firewall.php @@ -628,9 +628,8 @@ class Firewall extends Component 'enable' => $this->ruleEnable ? 1 : 0, ]; - if (!empty(trim($this->ruleMacro))) { - $payload['macro'] = trim($this->ruleMacro); - } + // Note: ruleMacro is only used for UI convenience to auto-populate fields + // It is NOT sent to Proxmox API - only the actual proto/dport values are sent if (!empty(trim($this->ruleIface))) { $payload['iface'] = trim($this->ruleIface);