From bbf96805dd7d91dbcdd0c828f639c7dfa85a0cc4 Mon Sep 17 00:00:00 2001
From: "Joseph.Rawlings" <root0091@gmail.com>
Date: Tue, 2 Dec 2025 16:37:00 -0500
Subject: [PATCH] refactor: implement firewall logs loading via API on page
 load, enhancing performance and user experience

---
 .../Database/Seeders/UptimeServerSeeder.php   |  74 +++++++
 .../Servers/Proxmox/Livewire/Firewall.php     |  23 +-
 .../Servers/Proxmox/views/firewall.blade.php  | 199 ++++++++++--------
 3 files changed, 208 insertions(+), 88 deletions(-)
 create mode 100644 extensions/Others/UptimeLab/Database/Seeders/UptimeServerSeeder.php

diff --git a/extensions/Others/UptimeLab/Database/Seeders/UptimeServerSeeder.php b/extensions/Others/UptimeLab/Database/Seeders/UptimeServerSeeder.php
new file mode 100644
index 000000000..13dde1a70
--- /dev/null
+++ b/extensions/Others/UptimeLab/Database/Seeders/UptimeServerSeeder.php
@@ -0,0 +1,74 @@
+<?php
+
+namespace Database\Seeders;
+
+use Illuminate\Database\Seeder;
+use Paymenter\Extensions\Others\UptimeLab\Models\UptimeServer;
+
+class UptimeServerSeeder extends Seeder
+{
+    /**
+     * Run the database seeds.
+     */
+    public function run(): void
+    {
+        $servers = [
+            [
+                'name' => 'Web Server 01',
+                'ip_address' => '192.168.1.10',
+                'server_type' => 'ip',
+                'location' => 'Jakarta, Indonesia',
+                'is_active' => true,
+                'status' => 'online',
+                'uptime_percentage' => 99.8,
+                'last_online' => now(),
+                'last_offline' => now()->subHours(6),
+                'last_check' => now(),
+                'response_time' => 15,
+            ],
+            [
+                'name' => 'Main Database Server',
+                'ip_address' => '192.168.1.20',
+                'server_type' => 'ip',
+                'location' => 'Surabaya, Indonesia',
+                'is_active' => true,
+                'status' => 'offline',
+                'uptime_percentage' => 100.0,
+                'last_online' => now()->subHours(5),
+                'last_offline' => now(),
+                'last_check' => now(),
+                'response_time' => null,
+            ],
+            [
+                'name' => 'API Gateway',
+                'ip_address' => 'api.example.com',
+                'server_type' => 'subdomain',
+                'location' => 'Bandung, Indonesia',
+                'is_active' => true,
+                'status' => 'online',
+                'uptime_percentage' => 99.9,
+                'last_online' => now()->subHours(6),
+                'last_offline' => now()->subHours(5),
+                'last_check' => now(),
+                'response_time' => 25,
+            ],
+            [
+                'name' => 'Load Balancer',
+                'ip_address' => '192.168.1.40',
+                'server_type' => 'ip',
+                'location' => 'Jakarta, Indonesia',
+                'is_active' => true,
+                'status' => 'online',
+                'uptime_percentage' => 99.99,
+                'last_online' => now(),
+                'last_offline' => now()->subHours(6),
+                'last_check' => now(),
+                'response_time' => 8,
+            ],
+        ];
+
+        foreach ($servers as $serverData) {
+            UptimeServer::create($serverData);
+        }
+    }
+}
diff --git a/extensions/Servers/Proxmox/Livewire/Firewall.php b/extensions/Servers/Proxmox/Livewire/Firewall.php
index 3db741fe9..d6dc9e701 100644
--- a/extensions/Servers/Proxmox/Livewire/Firewall.php
+++ b/extensions/Servers/Proxmox/Livewire/Firewall.php
@@ -58,7 +58,7 @@ class Firewall extends Component
         $this->loadFirewallOptions();
         $this->loadFirewallRules();
         $this->loadNetworkAdapters();
-        $this->loadFirewallLogs();
+        // Note: loadFirewallLogs() is now called only once via API on page load
     }
     
     protected function loadAvailableIps(): void
@@ -797,6 +797,27 @@ class Firewall extends Component
         }
     }
 
+    /**
+     * Public method to load firewall logs - called only once on page load via API
+     */
+    #[\Livewire\Attributes\Computed]
+    public function firewallLogs()
+    {
+        return $this->loadFirewallLogs();
+    }
+
+    /**
+     * Fetch firewall logs via API call - returns logs as JSON
+     */
+    public function fetchFirewallLogs(): array
+    {
+        $this->loadFirewallLogs();
+        return [
+            'logs' => $this->firewallLogs,
+            'error' => $this->logError,
+        ];
+    }
+
     public function loadFirewallLogs(): void
     {
         $this->logError = '';
diff --git a/extensions/Servers/Proxmox/views/firewall.blade.php b/extensions/Servers/Proxmox/views/firewall.blade.php
index c4077ea2a..dd2dc889b 100644
--- a/extensions/Servers/Proxmox/views/firewall.blade.php
+++ b/extensions/Servers/Proxmox/views/firewall.blade.php
@@ -303,94 +303,116 @@
                 </div>
             </div>
 
-            @if(!empty($logError))
-                <div class="bg-warning/10 border border-warning/30 rounded-lg p-4 mb-4">
-                    <div class="flex items-start gap-3">
-                        <x-ri-error-warning-line class="size-5 text-warning flex-shrink-0 mt-0.5" />
-                        <div class="flex-1">
-                            <p class="text-sm text-warning/90">{{ $logError }}</p>
-                        </div>
-                    </div>
-                </div>
-            @endif
+            <div id="firewall-logs-container"
+                x-data="{
+                    logs: [],
+                    loading: true,
+                    error: '',
+                    searchTerm: '',
+                    sortField: 'timestamp_iso',
+                    sortDirection: 'desc',
+                    async initializeLogs() {
+                        // Only load logs once on page load
+                        if (window.firewallLogsLoaded) {
+                            this.logs = window.firewallLogsData || [];
+                            this.loading = false;
+                            return;
+                        }
+                        
+                        try {
+                            // Call Livewire method to fetch logs
+                            const result = await @this.call('fetchFirewallLogs');
+                            window.firewallLogsData = result.logs || [];
+                            window.firewallLogsLoaded = true;
+                            this.logs = window.firewallLogsData;
+                            this.error = result.error || '';
+                        } catch (err) {
+                            this.error = 'Failed to load firewall logs: ' + (err.message || 'Unknown error');
+                            console.error('Error loading firewall logs:', err);
+                            this.logs = [];
+                        } finally {
+                            this.loading = false;
+                        }
+                    },
+                    sort(field) {
+                        if (this.sortField === field) {
+                            this.sortDirection = this.sortDirection === 'asc' ? 'desc' : 'asc';
+                        } else {
+                            this.sortField = field;
+                            this.sortDirection = 'asc';
+                        }
+                    },
+                    get filteredLogs() {
+                        const term = this.searchTerm.trim().toLowerCase();
+                        let entries = this.logs;
 
-            @once
-            <script>
-                if (typeof window.firewallLogsData === 'undefined') {
-                    window.firewallLogsData = @js($firewallLogs);
-                    window.firewallLogsLoaded = true;
-                }
-            </script>
-            @endonce
-            
-            @if(count($firewallLogs) > 0 || !empty($firewallLogs))
-                <div
-                    x-data="{
-                        logs: window.firewallLogsData || [],
-                        searchTerm: '',
-                        sortField: 'timestamp_iso',
-                        sortDirection: 'desc',
-                        sort(field) {
-                            if (this.sortField === field) {
-                                this.sortDirection = this.sortDirection === 'asc' ? 'desc' : 'asc';
-                            } else {
-                                this.sortField = field;
-                                this.sortDirection = 'asc';
-                            }
-                        },
-                        get filteredLogs() {
-                            const term = this.searchTerm.trim().toLowerCase();
-                            let entries = this.logs;
-
-                            if (term) {
-                                entries = entries.filter((log) => {
-                                    return Object.values(log).some((value) => {
-                                        if (value === null || value === undefined) {
-                                            return false;
-                                        }
-                                        return String(value).toLowerCase().includes(term);
-                                    });
+                        if (term) {
+                            entries = entries.filter((log) => {
+                                return Object.values(log).some((value) => {
+                                    if (value === null || value === undefined) {
+                                        return false;
+                                    }
+                                    return String(value).toLowerCase().includes(term);
                                 });
+                            });
+                        }
+
+                        const dir = this.sortDirection === 'asc' ? 1 : -1;
+                        const field = this.sortField;
+
+                        return entries.slice().sort((a, b) => {
+                            let aVal = a[field] ?? '';
+                            let bVal = b[field] ?? '';
+
+                            if (field === 'timestamp_iso') {
+                                const aTime = aVal ? new Date(aVal).getTime() : 0;
+                                const bTime = bVal ? new Date(bVal).getTime() : 0;
+                                return (aTime - bTime) * dir;
                             }
 
-                            const dir = this.sortDirection === 'asc' ? 1 : -1;
-                            const field = this.sortField;
+                            if (!Number.isNaN(parseFloat(aVal)) && !Number.isNaN(parseFloat(bVal))) {
+                                return (parseFloat(aVal) - parseFloat(bVal)) * dir;
+                            }
 
-                            return entries.slice().sort((a, b) => {
-                                let aVal = a[field] ?? '';
-                                let bVal = b[field] ?? '';
-
-                                if (field === 'timestamp_iso') {
-                                    const aTime = aVal ? new Date(aVal).getTime() : 0;
-                                    const bTime = bVal ? new Date(bVal).getTime() : 0;
-                                    return (aTime - bTime) * dir;
-                                }
-
-                                if (!Number.isNaN(parseFloat(aVal)) && !Number.isNaN(parseFloat(bVal))) {
-                                    return (parseFloat(aVal) - parseFloat(bVal)) * dir;
-                                }
-
-                                return String(aVal).localeCompare(String(bVal)) * dir;
-                            });
-                        },
-                    }"
-                    class="space-y-4"
-                >
-                    <div class="flex flex-col md:flex-row md:items-center md:justify-between gap-3">
-                        <div class="relative w-full md:w-72">
-                            <x-ri-search-line class="size-4 absolute left-3 top-1/2 -translate-y-1/2 text-base/40" />
-                            <input
-                                type="text"
-                                x-model="searchTerm"
-                                placeholder="Search logs..."
-                                class="firewall-log-search-input w-full pr-4 py-2 border border-neutral rounded-lg bg-background focus:outline-none focus:ring-2 focus:ring-primary/40"
-                            />
+                            return String(aVal).localeCompare(String(bVal)) * dir;
+                        });
+                    },
+                }"
+                @load="initializeLogs()"
+            >
+                    <div x-show="loading" x-cloak class="text-center py-8 text-base/60">
+                        <div class="animate-spin inline-block">
+                            <x-ri-loader-4-line class="size-8 mx-auto mb-3 opacity-50" />
                         </div>
-                        <div class="text-xs text-base/50">
-                            <span x-text="`${filteredLogs.length} / ${logs.length} results`"></span>
+                        <p>Loading firewall logs...</p>
+                    </div>
+
+                    <div x-show="error" x-cloak class="bg-error/10 border border-error/30 rounded-lg p-4">
+                        <div class="flex items-start gap-3">
+                            <x-ri-error-warning-line class="size-5 text-error flex-shrink-0 mt-0.5" />
+                            <div class="flex-1">
+                                <p class="text-sm text-error/90" x-text="error"></p>
+                            </div>
                         </div>
                     </div>
 
+                    <template x-if="!loading && !error && logs.length > 0">
+                        <div class="space-y-4">
+                            <div class="flex flex-col md:flex-row md:items-center md:justify-between gap-3">
+                                <div class="relative w-full md:w-72">
+                                    <x-ri-search-line class="size-4 absolute left-3 top-1/2 -translate-y-1/2 text-base/40" />
+                                    <input
+                                        type="text"
+                                        x-model="searchTerm"
+                                        placeholder="Search logs..."
+                                        class="firewall-log-search-input w-full pr-4 py-2 border border-neutral rounded-lg bg-background focus:outline-none focus:ring-2 focus:ring-primary/40"
+                                    />
+                                </div>
+                                <div class="text-xs text-base/50">
+                                    <span x-text="`${filteredLogs.length} / ${logs.length} results`"></span>
+                                </div>
+                            </div>
+
                     <div class="overflow-x-auto">
                         <table class="w-full border-collapse">
                             <thead>
@@ -993,14 +1015,17 @@
                         <x-ri-file-list-3-line class="size-12 mx-auto mb-3 opacity-50" />
                         <p>No logs matched your search.</p>
                     </div>
-                </div>
-            @elseif(empty($logError))
-                <div class="text-center py-8 text-base/60">
-                    <x-ri-file-list-3-line class="size-12 mx-auto mb-3 opacity-50" />
-                    <p>No firewall logs available</p>
-                    <p class="text-xs mt-2">Ensure firewall logging is enabled in Proxmox (Datacenter > Firewall > Options)</p>
-                </div>
-            @endif
+                        </div>
+                    </template>
+
+                    <template x-if="!loading && !error && logs.length === 0">
+                        <div class="text-center py-8 text-base/60">
+                            <x-ri-file-list-3-line class="size-12 mx-auto mb-3 opacity-50" />
+                            <p>No firewall logs available</p>
+                            <p class="text-xs mt-2">Ensure firewall logging is enabled in Proxmox (Datacenter > Firewall > Options)</p>
+                        </div>
+                    </template>
+            </div>
         </div>
     @else
         <div class="bg-background-secondary border border-neutral/20 rounded-lg p-8 text-center">