Joseph.Rawlings/Virtnet.bond
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Add error handling for backup location checks and improve backup fetching logic

Browse Source
This commit is contained in:
Joseph.Rawlings
2026-02-01 13:25:12 -05:00
parent d291a3b743
commit 8873192963
2 changed files with 49 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
extensions/Servers/Proxmox/Livewire/Backups/Create.php
View File

@@ -31,15 +31,25 @@ class Create extends Component
return true;
}
$proxmox = new Proxmox;
$currentBackups = $proxmox->request('/nodes/' . $this->server->node->name . '/storage/' . $this->server->node->backup_location . '/content', data: [
'content' => 'backup',
'vmid' => $this->server->vm_id,
])->json()['data'] ?? [];
// Check if backup_location is configured
if (empty($this->server->node->backup_location)) {
return false;
}
$currentBackupCount = count($currentBackups);
try {
$proxmox = new Proxmox;
$currentBackups = $proxmox->request('/nodes/' . $this->server->node->name . '/storage/' . $this->server->node->backup_location . '/content', data: [
'content' => 'backup',
'vmid' => $this->server->vm_id,
])->json()['data'] ?? [];
return $currentBackupCount < $backupLimit;
$currentBackupCount = count($currentBackups);
return $currentBackupCount < $backupLimit;
} catch (\Exception $e) {
\Illuminate\Support\Facades\Log::error('Failed to check backup limit: ' . $e->getMessage());
return false;
}
}
public function backup()
@@ -66,17 +76,22 @@ class Create extends Component
$backupSettings = $this->server->service->product->settings()->where('key', 'backups')->first();
$backupLimit = $backupSettings?->value ?? 0;
if ($backupLimit > 0) {
$proxmox = new Proxmox;
$currentBackups = $proxmox->request('/nodes/' . $this->server->node->name . '/storage/' . $this->server->node->backup_location . '/content', data: [
'content' => 'backup',
'vmid' => $this->server->vm_id,
])->json()['data'] ?? [];
if ($backupLimit > 0 && !empty($this->server->node->backup_location)) {
try {
$proxmox = new Proxmox;
$currentBackups = $proxmox->request('/nodes/' . $this->server->node->name . '/storage/' . $this->server->node->backup_location . '/content', data: [
'content' => 'backup',
'vmid' => $this->server->vm_id,
])->json()['data'] ?? [];
$currentBackupCount = count($currentBackups);
$currentBackupCount = count($currentBackups);
if ($currentBackupCount >= $backupLimit) {
$this->notify("Backup limit reached. You can only create {$backupLimit} backup(s). Please delete an existing backup before creating a new one.", 'error');
if ($currentBackupCount >= $backupLimit) {
$this->notify("Backup limit reached. You can only create {$backupLimit} backup(s). Please delete an existing backup before creating a new one.", 'error');
return;
}
} catch (\Exception $e) {
$this->notify('Failed to check backup limit: ' . $e->getMessage(), 'error');
return;
}
}

22
extensions/Servers/Proxmox/Livewire/Backups/Index.php
View File

@@ -34,10 +34,24 @@ class Index extends Component
return;
}
$this->backups = $proxmox->request('/nodes/' . $this->server->node->name . '/storage/' . $this->server->node->backup_location . '/content', data: [
'content' => 'backup',
'vmid' => $this->server->vm_id,
])->json()['data'];
// Check if backup_location is configured
if (empty($this->server->node->backup_location)) {
$this->backups = [];
return;
}
try {
$response = $proxmox->request('/nodes/' . $this->server->node->name . '/storage/' . $this->server->node->backup_location . '/content', data: [
'content' => 'backup',
'vmid' => $this->server->vm_id,
]);
$this->backups = $response->json()['data'] ?? [];
} catch (\Exception $e) {
$this->backups = [];
// Log the error for debugging
\Illuminate\Support\Facades\Log::error('Failed to fetch backups: ' . $e->getMessage());
}
}
public function restoreBackup()